Arm64: Fix perfscore and display logic for LARGELDC #59134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsFor LARGELDC format to load large constant, we were missing a case during perf score calculation. Also, the size assert during displaying instruction should be based on Found from Antigen, the repro needs large code and lot of constants (the repro had around 14000 local variables.
|
jakobbotsch
approved these changes
Sep 15, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For LARGELDC format to load large constant, we were missing a case during perf score calculation. Also, the size assert during displaying instruction should be based on
idCodeSize().Found from Antigen, the repro needs large code and lot of constants (the repro had around 14000 local variables.